Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run initial commands for a program. #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

takaczapka
Copy link

This pull request adds the ability to run commands on init when the application starts. In our case we needed this functionality to test our application. Please review and give any feedback so that this can be incorporated in the official repo.

@gdotdesign
Copy link
Owner

It's a nice feature 😄 and the PR looks good 👍 I can merge and do a release if you exclude the last commit.

@kingsleyh
Copy link

This pull request will be superseded by a better solution coming later today

@takaczapka
Copy link
Author

Hello again, the previous change was no good. We have found out a few issues with it:

  • command was run only once for all tests, but it should run for each test, the same way appInit() is run,
  • It was having problems when initCmd was using a command which was using HTTP directly (not through Task.perform Message) - then HTTP mocks wouldn't get initialized in time

Current implementation is solving those problems. I hope it is good enough in your opinion to be merged into original code. Thanks a lot and please let me know what you think!

@takaczapka
Copy link
Author

Hello,

Please let me know if you need any help or information regarding this pull request. I'm happy to pair with you if something is unclear.

There's one more change we would like to incorporate into elm-spec. It's a about inputing data through ports. Please check https://github.com/takaczapka/elm-spec/tree/chupa "Interaction with ports" documentation section.

Cheers,
Maciej

@samstickland
Copy link

Hi,

I have need of this PR too. Is there anything I can help with to get this merged?

@samstickland samstickland mentioned this pull request Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants